Cherry-pick upstream LuaJIT interpreter onto Shopify main#43
Draft
dalehamel wants to merge 6 commits into
Draft
Conversation
…igest to 5939a84 (open-telemetry#1363) Signed-off-by: Florian Lehner <florian.lehner@elastic.co> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Florian Lehner <florian.lehner@elastic.co>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Signed-off-by: Florian Lehner <florian.lehner@elastic.co> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Florian Lehner <florian.lehner@elastic.co>
This PR contains an interpreter for LuaJIT code, which is primarily useful in practice due to OpenResty. It has been used in Parca/Polar Signals since Nov. 2024. A thorough explanation of the approach used as well as an introduction to Lua internals can be found at the accompanying blog post: https://www.polarsignals.com/blog/posts/2024/11/13/lua-unwinding .
This was referenced Apr 24, 2026
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Cherry-picks the upstream LuaJIT interpreter support from open-telemetry/opentelemetry-ebpf-profiler onto our Shopify fork's
main.Upstream commits included:
63660c3— Add LuaJIT interpreter (Brennan Vincent, upstream PR Add LuaJIT interpreter open-telemetry/opentelemetry-ebpf-profiler#1236)fe68d2f— Report correct PID from LuaJIT unwinder (Generalize walking through frames in a reporter open-telemetry/opentelemetry-ebpf-profiler#229, umanwizard)f5146df,967c3a7,5c75fdc,5aeb82e— dependency updates required by the LuaJIT codeThis branch serves as the base for PR #42 (
dale/luajit-unwinder), which contains our Shopify-specific hardening (map pressure fixes, verifier budget tuning, diagnostics).Review
This is pure upstream code — the diff should match what's already merged in the upstream repo. Our modifications are in PR #42.