fix parsing quirky incomplete expressions #1838
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ianks
reviewed
Oct 30, 2024
lib/liquid/lexer.rb
Outdated
| @output << found | ||
| @ss.scan_byte | ||
| else | ||
| raise SyntaxError, "Unexpected character #{peeked.chr}" | ||
| end | ||
| elsif (sub_table = COMPARISON_JUMP_TABLE[peeked]) | ||
| @ss.scan_byte | ||
| if (found = sub_table[@ss.peek_byte]) | ||
| if [email protected]? && (found = sub_table[@ss.peek_byte]) |
There was a problem hiding this comment.
Suggested change
| if !@ss.eos? && (found = sub_table[@ss.peek_byte]) | |
| if (peeked = @ss.peek_byte) && (found = sub_table[peeked]) |
ianks
approved these changes
Oct 30, 2024
ggmichaelgo
force-pushed
the
quirky-lexer-parsing
branch
from
9a3f14f to
ffce6de
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1832 introduced a new bug in lax parsing, and prevented incomplete expression from pasing.
Example Liquid code:
{% liquid assign foo = false - %}