Setup databases for integration tests with dev#31
Closed
bbuchalter wants to merge 2 commits intomasterfrom
Closed
Conversation
added 2 commits
July 12, 2018 12:17
* Do not specify dependencies in Gemfile (this is a gem) * rake was already in gemspec causing bundler to complain * added package_cloud to gemspec * Change `mysql` to `mysql2` because `mysql` is so ancient it won't even compile * Add Gemfile.lock - this is now considered best practice: rubygems/bundler#6184
These tests are critical to exercising LHM. We need this to be as easy as possible for developers to run, so let's automate it.
Closed
Author
|
Superseded by #32 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These tests are critical to exercising LHM. We need this to be as easy as
possible for developers to run, so let's automate it.
This also fixes dependencies:
mysqltomysql2becausemysqlis so ancient it won't evencompile
Update docs to reflect revised guidance to check in locks for gems rubygems/bundler#6184
Test with:
Unit tests are known to be failing right now, but you can at least run them with
dev unit.