-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Krane annotations #539
Conversation
0361d4f
to
948d680
Compare
246ffc8
to
f643581
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks on track, only big concern is DRYing it up.
test/unit/kubernetes-deploy/kubernetes_resource/deployment_test.rb
Outdated
Show resolved
Hide resolved
8f95924
to
3098276
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I really like how you DRY'd up the code with krane_annotation_value
. I was envisioning doing the same thing with the *_annotation_key
methods. Is there a reason I'm not seeing why its a bad idea?
Not at all, I went back over it and got it sorted out. Sorry for overlooking that. Ready for another 👀 |
1b310da
to
b2c4633
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just added a small question but it looks good to me!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
6e7b7ad
to
3b4daed
Compare
- Deprecate kubernetes-deploy.shopify.io annotations - Edit readme to reflect new annotations - Add annotation deprecation changelog entry - Add warning on use of depricated annotation during deploy task co-authored-by: Ryan Brushett <[email protected]>
3b4daed
to
d237e0c
Compare
What are you trying to accomplish with this PR?
Closes: #525
As described in the issue, we want to support new Krane annotations while allowing the current
kubernetes-deploy
annotations to remain in use.I think we should break this down into three steps:
kubernetes-deploy
annotation is used, indicating thatkrane.shopify.io
should be used insteadHow is this accomplished?
(Chatted with @dturn and we decided that duplicating every test that makes use of an annotated resource is unnecessary)
What could go wrong?
kubernetes-deploy.shopify.io/ejson-secret
). Discussion about it's purpose can be found here: Deploy secrets in DeployTask like other resources #424. I've excluded it from this PR - thinking we might want to tackle that for this issue instead Rename code references ofkubernetes-deploy
tokrane
#527 since it's really just a tracking reference.