Prevent duplicate deprecated template warnings

lib/kubernetes-deploy/kubernetes_resource.rb

@@ -425,12 +425,14 @@ def validate_timeout_annotation
     end
 
     def validate_annotation_version
+      return if validation_warning_msg.include?("annotations is deprecated")
       annotation_keys = @definition.dig("metadata", "annotations")&.keys
       annotation_keys&.each do |annotation|
         if annotation.include?("kubernetes-deploy.shopify.io")
           annotation_prefix = annotation.split('/').first
           @validation_warnings << "#{annotation_prefix} as a prefix for annotations is deprecated: "\
             "Use the 'krane.shopify.io' annotation prefix instead"
+          return
         end
       end
     end

test/unit/kubernetes-deploy/kubernetes_resource_test.rb

@@ -106,6 +106,20 @@ def test_deprecated_annotation_generates_warning
       customized_resource.validation_warning_msg)
   end
 
+  def test_multiple_deprecated_annotations_generates_only_one_warning
+    definition_extras = build_timeout_metadata("60S", use_deprecated: true).dup
+    definition_extras['metadata']['annotations']['kubernetes-deploy.shopify.io/something'] = "thing"
+    customized_resource = DummyResource.new(definition_extras: definition_extras)
+    customized_resource.validate_definition(kubectl)
+
+    warning_message = <<~MESSAGE.strip
+      kubernetes-deploy.shopify.io as a prefix for annotations is deprecated: Use the 'krane.shopify.io' annotation prefix instead
+    MESSAGE
+
+    assert(customized_resource.has_warnings?, "Deprecated annotation did not generate a warning")
+    assert_equal(customized_resource.validation_warning_msg, warning_message)
+  end
+
   def test_valid_annotations_generate_no_warning
     customized_resource = DummyResource.new(definition_extras: build_timeout_metadata("60S"))
     customized_resource.validate_definition(kubectl)