[WIP] Capture admission hook changes of created resources #971
+166
−30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lib/krane/kubernetes_resource.rb
Outdated
Comment on lines
393
to
395
| definition.delete("status") | ||
| definition["metadata"].delete("resourceVersion") | ||
| definition |
There was a problem hiding this comment.
The result of kubectl create -ojson is the full representation of the resource, including things like status, resourceVersion, creationTimestamp, etc.
The subsequent apply fails if status is present and resourceVersion. The resourceVersion field has churn and fails if we don't remove it. This points to a possible bug, though. If the object is updated by another out-of-band process (NOT the admission controller), we may accidentally overwrite any changes when reapplying the oversampled resource definition.
A possible solution would be to walk each resource's definition file and update only those fields that are already present.
|
Closed in favor of #972 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are you trying to accomplish with this PR?
...
How is this accomplished?
...
What could go wrong?
...