Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure default line limit for container logs #803

Merged
merged 1 commit into from
Feb 11, 2021
Merged

Conversation

jenshenny
Copy link
Contributor

What are you trying to accomplish with this PR?
From #800, it was suggested to make DEFAULT_LINE_LIMIT configurable by introducing an environment variable.

How is this accomplished?
Turned the constant into a class method, if ENV["LOG_LINE_LIMIT"] (name open to suggestions) is not specified or cannot be converted to an integer, the number of lines will default to 25.

@jenshenny jenshenny marked this pull request as ready for review February 11, 2021 14:08
@jenshenny jenshenny requested a review from a team as a code owner February 11, 2021 14:08
CHANGELOG.md Outdated Show resolved Hide resolved
Copy link
Contributor

@casperisfine casperisfine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

CHANGELOG.md Outdated Show resolved Hide resolved
@dturn dturn merged commit db459a3 into master Feb 11, 2021
@dturn dturn deleted the configure-line-limit branch February 11, 2021 19:07
@jenshenny jenshenny mentioned this pull request Feb 22, 2021
@jenshenny jenshenny temporarily deployed to rubygems February 22, 2021 19:08 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants