Stop deploys if ClusterResourceDiscovery's kubectl calls fail #701
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dturn
force-pushed
the
resource-discovery-kubectl-failures
branch
from
1e8b1d4
to
e4ce2a5
Compare
dturn
force-pushed
the
resource-discovery-kubectl-failures
branch
from
e4ce2a5
to
c7ce382
Compare
KnVerey
approved these changes
Feb 20, 2020
KnVerey
pushed a commit
that referenced
this pull request
Apr 13, 2020
* Stop deploys if ClusterResourceDiscovery's kubectl calls fail
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are you trying to accomplish with this PR?
Currently we allow the kubectl calls in ClusterResourceDiscovery to fail with only warnings logged. However, this leads to funky behavior. We should have consistent and safe behavior.
Closes: #681
How is this accomplished?
Raise an error to stop the deploy if kubectl calls fail.
What could go wrong?
We could block deploys when the cluster is partially unhealthy (e.g. the external metric server is down).