Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove cloudsql hardcoded resource #680

Merged
merged 2 commits into from
Jan 29, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@

*Other*
- Reduces the number of container logs printed for failures from 250 to 25 to reduce noise. [#676](https://github.com/Shopify/krane/pull/676)
- Remove hardcoded cloudsql class. [#680](https://github.com/Shopify/krane/pull/680)

## 1.1.1

Expand Down
1 change: 0 additions & 1 deletion lib/krane/deploy_task.rb
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@
require 'krane/kubernetes_resource'
%w(
custom_resource
cloudsql
config_map
deployment
ingress
Expand Down
44 changes: 0 additions & 44 deletions lib/krane/kubernetes_resource/cloudsql.rb

This file was deleted.

8 changes: 0 additions & 8 deletions test/unit/krane/kubernetes_resource_test.rb
Original file line number Diff line number Diff line change
Expand Up @@ -454,14 +454,6 @@ def test_lowercase_custom_resource_kind_does_not_raise
end

def test_build_handles_hardcoded_and_core_and_dynamic_objects
# Hardcoded CRs
cloudsql_crd = Krane::KubernetesResource.build(namespace: "test", context: "test",
logger: @logger, statsd_tags: [], definition: build_crd(name: "cloudsql"))
cloudsql_cr = Krane::KubernetesResource.build(namespace: "test", context: "test",
logger: @logger, statsd_tags: [], crd: cloudsql_crd,
definition: { "kind" => "Cloudsql", "metadata" => { "name" => "test" } })
assert_equal(cloudsql_cr.class, Krane::Cloudsql)

# Dynamic with no rollout config
no_config_crd = Krane::KubernetesResource.build(namespace: "test", context: "test",
logger: @logger, statsd_tags: [], definition: build_crd(name: "noconfig"))
Expand Down