Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deploy secrets in DeployTask like other resources #424

Merged
merged 14 commits into from
Mar 1, 2019
Merged

Deploy secrets in DeployTask like other resources #424

merged 14 commits into from
Mar 1, 2019

Commits on Mar 1, 2019

  1. Add Secret resource

    @DazWorrall
    DazWorrall committed Mar 1, 2019
    Configuration menu
    Copy the full SHA
    e48239d View commit details
    Browse the repository at this point in the history

  2. Refactor EjsonSecretProvisioner to provide resources

    @DazWorrall
    DazWorrall committed Mar 1, 2019
    Configuration menu
    Copy the full SHA
    b84f420 View commit details
    Browse the repository at this point in the history

  3. Refactor kubectl sensitive output config

    @DazWorrall
    DazWorrall committed Mar 1, 2019
    Configuration menu
    Copy the full SHA
    b05aff2 View commit details
    Browse the repository at this point in the history

  4. Deploy resources from EjsonSecretProvisioner

    @DazWorrall
    DazWorrall committed Mar 1, 2019
    Configuration menu
    Copy the full SHA
    aa4cc7b View commit details
    Browse the repository at this point in the history

  5. Secrets as resources review fixes (#425) 

    Thanks so much @benlangfeld for your help with these:

* Remove excess logging

* Stop referring to EJSON secrets as generically "managed"

* Consistent timeout for Secret resources

Unifying the constant used for simple resources of this type is left as an exercise for another change, mostly because the name of such a thing may be controversial and I don't want to block merging this on detailed review.

* Give secrets the same statsd tags as other resources

* Removes duplicate spec

Doesn't test anything more than test_create_and_update_secrets_from_ejson

* Replaces log assertion

* Point out breaking changes in CHANGELOG

* Include ejson generated secrets in discovery log
    @benlangfeld @DazWorrall
    benlangfeld authored and DazWorrall committed Mar 1, 2019
    Configuration menu
    Copy the full SHA
    b378318 View commit details
    Browse the repository at this point in the history

  6. Misc review feedback 

    * Rebase on master
* Fix changelog after rebase
* Remove unnecessary logging
* Fix unknown Secret status
* Update test name to not include 'update'
* Write new unrecognized resource test
    @DazWorrall
    DazWorrall committed Mar 1, 2019
    Configuration menu
    Copy the full SHA
    5c6bea5 View commit details
    Browse the repository at this point in the history

  7. Hide some validation and deploy output when deploying sensitive 

    resources
    @DazWorrall
    DazWorrall committed Mar 1, 2019
    Configuration menu
    Copy the full SHA
    ade8c51 View commit details
    Browse the repository at this point in the history

  8. Better logging when handling failures with sensitive resources

    @DazWorrall
    DazWorrall committed Mar 1, 2019
    Configuration menu
    Copy the full SHA
    67bb1b9 View commit details
    Browse the repository at this point in the history

  9. Typo

    @benlangfeld
    benlangfeld committed Mar 1, 2019
    Configuration menu
    Copy the full SHA
    c3acf91 View commit details
    Browse the repository at this point in the history

  10. Catch more specific Kubectl error output

    @benlangfeld
    benlangfeld committed Mar 1, 2019
    Configuration menu
    Copy the full SHA
    9e13b30 View commit details
    Browse the repository at this point in the history

  11. Suppresses error messages on invalid sensitive templates

    @benlangfeld
    benlangfeld committed Mar 1, 2019
    Configuration menu
    Copy the full SHA
    b7a7026 View commit details
    Browse the repository at this point in the history

  12. This is not flaky any more (finer-grained assertion on kubectl error)

    @benlangfeld
    benlangfeld committed Mar 1, 2019
    Configuration menu
    Copy the full SHA
    eb94bbe View commit details
    Browse the repository at this point in the history

  13. Minor review fixes

    @benlangfeld
    benlangfeld committed Mar 1, 2019
    Configuration menu
    Copy the full SHA
    16f6411 View commit details
    Browse the repository at this point in the history

  14. Merge pull request #438 from powerhome/secrets-as-resources-more-revi… 

    …ew-feedback

Secrets as resources: more review feedback
    @KnVerey
    KnVerey authored Mar 1, 2019
    Configuration menu
    Copy the full SHA
    022a78f View commit details
    Browse the repository at this point in the history