-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Krane deploy error with prune whitelist - error: no matches for kind "Job" in version "batch/v2alpha1" #687
Comments
|
Thanks for the bug report, looks like we're going to have to put in an override for job https://github.com/Shopify/krane/blob/master/lib/krane/cluster_resource_discovery.rb#L87 |
@sco11morgan would you be interested in PRing this fix, I'm happy to provide guidance. |
@dturn sure. Just add an override of |
That's the small fix. The other idea might be update the code in that function not to use |
I already had the PR up for the small fix. I can look at a more general solution but won't be able to get to it for a couple of days. |
I'm getting the same error on GKE
Failed command:
Explain:
Could you folks explain more about the general fix for this? I don't quite understand, and am happy to PR the small fix again for this resource but I wonder what a more sustainable version looks like. |
Fixes ``` error: no matches for kind "FrontendConfig" in version "networking.gke.io/v1" ``` when pruning resources on GKE clusters >= 1.17.9-gke.6300 See Shopify#687 for more details
This should be resolved for ever by #778 |
Bug report
During a deploy an error occurs because of the values in the generated prune whitelist. This started happening after we updated our cluster to Kubernetes 1.16
List contained
Expected behavior: Expected pruning to perform normally.
Actual behavior: Error with supplied list of items to be pruned.
Version(s) affected: 1.1.1
Feature request
Proposal: [provide details on the behaviour you'd like to see and why it would be useful]
1 This is the quickest way to get a new feature! We reserve the right to close feature requests, even ones we like, if the proposer does not intend to contribute to the feature and it doesn't fit in our current roadmap.
The text was updated successfully, but these errors were encountered: