PR feedback

Shopify · Nov 12, 2019 · 5180093 · 5180093
1 parent 482f850
commit 5180093
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/1.0-Upgrade.md b/1.0-Upgrade.md
@@ -35,7 +35,7 @@ Old command | New command
 
 The following tables provide a mapping of the flags previously supported in `kubernetes-deploy` and their new version in `krane` (if applicable).
 
-Important: you can't repeat flags. If you need to provide multiple arguments for a flag, use a space-separated list (e.g. `-f file1.txt file2.txt`) unless specified otherwise.
+Important: you can't repeat flags. If you need to provide multiple arguments for a flag, use a space-separated list (e.g. `-f file1.yml file2.yml`) unless specified otherwise.
 
 #### krane deploy
 
@@ -47,7 +47,7 @@ Old flag | New flag | Comments
 --no-prune | --prune=true |
 --template-dir | -f, --filename | Makes all our commands accept this arg, which is now required for the deploy task
 --verbose-log-prefix | --verbose-log-prefix |
---max-watch-seconds=seconds | --global-timeout=300s | Changed flag name and default value
+--max-watch-seconds=seconds | --global-timeout=300s | Changed flag name and default value to be a duration (expressed using strings like "300s" or "1h")
 --selector | --selector |
 -h, --help | -h, --help |
 -v, --version | [none] | Replaced with `krane version`
@@ -60,15 +60,15 @@ $REVISION | --current-sha | The environment variable REVISION was dropped in fav
 Old flag | New flag | Comments
 --- | --- | ---
 --deployments=LIST | --deployments=LIST |
---max-watch-seconds=seconds | --global-timeout=300s | Changed flag name and default value
+--max-watch-seconds=seconds | --global-timeout=300s | Changed flag name and default value to be a duration (expressed using strings like "300s" or "1h")
 [none] | --verify-result=true | Define whether it should wait for results or exit immediately after validation
 
 #### krane run
 
 Old flag | New flag | Comments
 --- | --- | ---
 --skip-wait | --verify-result=true |
---max-watch-seconds=seconds | --global-timeout=300s | Changed flag name and default value
+--max-watch-seconds=seconds | --global-timeout=300s | Changed flag name and default value to be a duration (expressed using strings like "300s" or "1h")
 --entrypoint | --command | Changed flag name to make its purpose clearer
 --template | --template | Changed to be required
 [it is positional now] | --arguments | Optional flag, as `command` or the template might already specify the required arguments