Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix events route #915

Merged
merged 1 commit into from
May 19, 2023
Merged

Fix events route #915

merged 1 commit into from
May 19, 2023

Conversation

frehner
Copy link
Contributor

@frehner frehner commented May 19, 2023

WHY are these changes introduced?

Fixes #875
Fixes #911

Related to https://github.com/Shopify/mini-oxygen/pull/436

WHAT is this pull request doing?

Pulls in the latest update for mini-oxygen, which fixes a routing issue.

Checklist

  • I've read the Contributing Guidelines
  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've added a changeset if this PR contains user-facing or noteworthy changes
  • I've added tests to cover my changes
  • I've added or updated the documentation

@frehner frehner merged commit 3cc6d75 into 2023-04 May 19, 2023
@frehner frehner deleted the fix-events-route branch May 19, 2023 16:16
@shopify-github-actions-access shopify-github-actions-access bot mentioned this pull request May 19, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juanpprieto juanpprieto juanpprieto approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Events route Routing issue in dev /events
2 participants
@frehner @juanpprieto