Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reorder fragments #833

Merged
merged 3 commits into from
May 1, 2023
Merged

Reorder fragments #833

merged 3 commits into from
May 1, 2023

Conversation

frehner
Copy link
Contributor

@frehner frehner commented Apr 28, 2023

WHY are these changes introduced?

Fixes #826

WHAT is this pull request doing?

Just moves the fragments to the end of the query to avoid a visual error in the VSCode GraphQL plugin.

Both work, but this way doesn't give a weird error.

Checklist

  • I've read the Contributing Guidelines
  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've added a changeset if this PR contains user-facing or noteworthy changes
  • I've added tests to cover my changes
  • I've added or updated the documentation

@frehner frehner requested a review from a team April 28, 2023 19:45
@frehner frehner merged commit fc3c3eb into 2023-04 May 1, 2023
@frehner frehner deleted the reorder-fragments branch May 1, 2023 16:38
@shopify-github-actions-access shopify-github-actions-access bot mentioned this pull request May 1, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frandiox frandiox frandiox approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Graphql error on the template
2 participants
@frehner @frandiox