Fix demo store search action base url #802
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ocordova
changed the title
|
I just signed the Shopify’s CLA (: |
|
Should we have merged this also to |
tiwac100
added a commit
to tiwac100/hydrogen
that referenced
this pull request
Apr 27, 2023
This reverts commit a783b42.
Great catch; yes to both I believe! |
blittle
pushed a commit
that referenced
this pull request
May 12, 2023
frehner
added a commit
that referenced
this pull request
May 17, 2023
* Fix 2023 01 (#807) * Revert "Support optional segments in `check routes` CLI command (#774)" This reverts commit 2039a4a. * update package.lock * Fix demo store search action url (#802) * Fixing #825 * Add loading dependency to redirect effect * Revert "Fix 2023 01 (#807)" This reverts commit 53e6dbf. * Revert "Fix demo store search action url (#802)" This reverts commit a783b42. * add a changeset --------- Co-authored-by: Daniel Rios <[email protected]> Co-authored-by: Ós <[email protected]> Co-authored-by: Anthony Frehner <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
targetproperty in theSearchActionmust be the base url, right now it's using the request.url that is the full path, and it's missing the trailing slash, resulting inhttps://hydrogen.shop/products/the-full-stacksearch?q={search_term}instead ofhttps://hydrogen.shop/search?q={search_term}for product detail pages.By the way, I'm using the URL origin property since I didn't see a domain constant and shop.primaryDomain won't be the custom domain name. If you have a better alternative, let me know.
Checklist