Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix parse gid #723

Merged
merged 4 commits into from
Mar 28, 2023
Merged

Fix parse gid #723

merged 4 commits into from
Mar 28, 2023

Conversation

wizardlyhel
Copy link
Contributor

#701

WHY are these changes introduced?

The cart token got updated and we are not parsing properly.

WHAT is this pull request doing?

Make sure we accept the following style of cart token:

  • gid://shopify/Cart/c1-3d2419bf79df5e91d37b449cc6cd0ba1?test=123
  • gid://shopify/Cart/c1-3d2419bf79df5e91d37b449cc6cd0ba1

Checklist

  • I've read the Contributing Guidelines
  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've added a changeset if this PR contains user-facing or noteworthy changes
  • I've added tests to cover my changes
  • I've added or updated the documentation

frehner
frehner approved these changes Mar 28, 2023
View reviewed changes
.changeset/dry-snails-relax.md Outdated Show resolved Hide resolved
@wizardlyhel wizardlyhel merged commit 85ae63a into 2023-01 Mar 28, 2023
@wizardlyhel wizardlyhel deleted the fix-parse-gid branch March 28, 2023 17:26
@github-actions github-actions bot mentioned this pull request Mar 28, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frandiox frandiox frandiox approved these changes

@frehner frehner frehner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wizardlyhel @frandiox @frehner