Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove double body in b2b example #2352

Merged
merged 1 commit into from
Jul 24, 2024
Merged

Conversation

BernhardRieder1
Copy link
Contributor

The b2b example renders the PageLayout(The entire content of the page) twice, this fixes that

WHAT is this pull request doing?

It removes the duplicate <PageLayout {...data}>{children}</PageLayout> call

Checklist

  • I've read the Contributing Guidelines
  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've added a changeset if this PR contains user-facing or noteworthy changes
  • I've added tests to cover my changes
  • I've added or updated the documentation

Copy link
Contributor

shopify bot commented Jul 19, 2024

Oxygen deployed a preview of your main branch. Details:

Storefront Status Preview link Deployment details Last update (UTC)
custom-cart-method ✅ Successful (Logs) Preview deployment Inspect deployment July 23, 2024 9:48 PM
third-party-queries-caching ✅ Successful (Logs) Preview deployment Inspect deployment July 23, 2024 9:48 PM
classic-remix ✅ Successful (Logs) Preview deployment Inspect deployment July 23, 2024 9:48 PM
metaobjects ✅ Successful (Logs) Preview deployment Inspect deployment July 23, 2024 9:48 PM
Skeleton (skeleton.hydrogen.shop) ✅ Successful (Logs) Preview deployment Inspect deployment July 23, 2024 9:48 PM
optimistic-cart-ui ✅ Successful (Logs) Preview deployment Inspect deployment July 23, 2024 9:48 PM

Learn more about Hydrogen's GitHub integration.

@BernhardRieder1
Copy link
Contributor Author

I have signed the CLA!

Copy link
Contributor

@blittle blittle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution!

@blittle blittle merged commit 5339006 into Shopify:main Jul 24, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants