Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Shopify's default auth flow #2331

Merged
merged 9 commits into from
Jul 16, 2024
Merged

Use Shopify's default auth flow #2331

merged 9 commits into from
Jul 16, 2024

Conversation

graygilmore
Copy link
Contributor

@graygilmore graygilmore commented Jul 15, 2024

Closes #2335

Copy link
Contributor

shopify bot commented Jul 15, 2024

Oxygen deployed a preview of your gg-remove-auth-hijack branch. Details:

Storefront Status Preview link Deployment details Last update (UTC)
metaobjects ✅ Successful (Logs) Preview deployment Inspect deployment July 16, 2024 4:05 PM
custom-cart-method ✅ Successful (Logs) Preview deployment Inspect deployment July 16, 2024 4:04 PM
classic-remix ✅ Successful (Logs) Preview deployment Inspect deployment July 16, 2024 4:04 PM
Skeleton (skeleton.hydrogen.shop) ✅ Successful (Logs) Preview deployment Inspect deployment July 16, 2024 4:04 PM
third-party-queries-caching ✅ Successful (Logs) Preview deployment Inspect deployment July 16, 2024 4:05 PM
optimistic-cart-ui ✅ Successful (Logs) Preview deployment Inspect deployment July 16, 2024 4:04 PM

Learn more about Hydrogen's GitHub integration.

@frandiox
Copy link
Contributor

@graygilmore I've updated to cli-kit 3.64 in #2337 to surface the actual auth problem, and merged in this branch.
Since removing the login command is a big change for a patch release, I've reverted that and enhanced the logs a little bit.

@frandiox frandiox marked this pull request as ready for review July 16, 2024 15:59
@frandiox frandiox requested a review from a team July 16, 2024 15:59

This comment has been minimized.

@frandiox
Copy link
Contributor

/snapit

Copy link
Contributor

🫰✨ Thanks @frandiox! Your snapshot has been published to npm.

Test the snapshot by updating your package.json with the newly published version:

"@shopify/cli-hydrogen": "0.0.0-snapshot-20240716160423"

@frandiox
Copy link
Contributor

/snapit

Copy link
Contributor

🫰✨ Thanks @frandiox! Your snapshot has been published to npm.

Test the snapshot by updating your package.json with the newly published version:

"@shopify/cli-hydrogen": "0.0.0-snapshot-20240716163954"

@frandiox frandiox merged commit 8b2322d into main Jul 16, 2024
13 checks passed
@frandiox frandiox deleted the gg-remove-auth-hijack branch July 16, 2024 16:41
@frandiox frandiox mentioned this pull request Aug 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to create linked Hydrogen repo
2 participants