Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix shopify cookie with leading dot domain #2142

Merged
merged 3 commits into from
May 22, 2024
Merged

Conversation

wizardlyhel
Copy link
Contributor

@wizardlyhel wizardlyhel commented May 22, 2024

WHY are these changes introduced?

It looks like checkout is re-assigning _shopify_y and _shopify_s cookie if the domain is not set with a leading period when used with customer privacy api. (Validated issue with hydrogen.shop)

WHAT is this pull request doing?

Make sure leading period is added to cookie domain if not present.

HOW to test your changes?

Post-merge steps

Checklist

  • I've read the Contributing Guidelines
  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've added a changeset if this PR contains user-facing or noteworthy changes
  • I've added tests to cover my changes
  • I've added or updated the documentation

Copy link
Contributor

shopify bot commented May 22, 2024

Oxygen deployed a preview of your hl-fix-cookie-domain branch. Details:

Storefront Status Preview link Deployment details Last update (UTC)
custom-cart-method ✅ Successful (Logs) Preview deployment Inspect deployment May 22, 2024 5:35 PM
third-party-queries-caching ✅ Successful (Logs) Preview deployment Inspect deployment May 22, 2024 5:35 PM
subscriptions ✅ Successful (Logs) Preview deployment Inspect deployment May 22, 2024 5:36 PM
Skeleton (skeleton.hydrogen.shop) ✅ Successful (Logs) Preview deployment Inspect deployment May 22, 2024 5:35 PM
optimistic-cart-ui ✅ Successful (Logs) Preview deployment Inspect deployment May 22, 2024 5:36 PM
vite ✅ Successful (Logs) Preview deployment Inspect deployment May 22, 2024 5:36 PM

Learn more about Hydrogen's GitHub integration.

This comment has been minimized.

Copy link
Contributor

@blittle blittle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How do we validate this on Hydrogen.shop before merging? Upgrade hydrogen.shop to the next release?

@wizardlyhel
Copy link
Contributor Author

wizardlyhel commented May 22, 2024

That is what I was thinking too, upgrade to next for hydrogen.shop

@wizardlyhel wizardlyhel merged commit 73716c8 into main May 22, 2024
13 checks passed
@wizardlyhel wizardlyhel deleted the hl-fix-cookie-domain branch May 22, 2024 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants