Fix shopify cookie with leading dot domain #2142
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
It looks like checkout is re-assigning
_shopify_y
and_shopify_s
cookie if the domain is not set with a leading period when used with customer privacy api. (Validated issue with hydrogen.shop)WHAT is this pull request doing?
Make sure leading period is added to cookie domain if not present.
HOW to test your changes?
Post-merge steps
Checklist