demo-store customer account api update #1647
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We detected some changes in |
michenly
force-pushed
the
mc-demo-store-caapi
branch
2 times, most recently
from
8fe2e21 to
19c50c7
Compare
michenly
commented
Jan 17, 2024
.eslintrc.js
Outdated
| @@ -10,38 +10,4 @@ module.exports = { | |||
| 'no-useless-escape': 'off', | |||
| 'no-case-declarations': 'off', | |||
| }, | |||
| overrides: [ | |||
There was a problem hiding this comment.
This override and templates/demo-store/.eslintrc.js are causing some issue where the VS Code eslint suggestion and the one in CI are giving different suggestions.
There is probably something to fix, but do we really need this override?
There was a problem hiding this comment.
blittle
reviewed
Jan 17, 2024
Co-authored-by: Bret Little <[email protected]>
Co-authored-by: Bret Little <[email protected]>
michenly
force-pushed
the
mc-demo-store-caapi
branch
from
de2c52c to
5cba418
Compare
michenly
merged commit 51adf14
into
mc-customer-account-templates-update
7 of 10 checks passed
michenly
added a commit
that referenced
this pull request
Jan 18, 2024
…re` (#1576) * ✨ add type generation for customer account api in app/graphql/customer folder * ✨ add customer client creation into remix server context * 🔥 remove account activate, recover, register and reset. Since these are not supported in the new CA API with new customer flow. * 💥 get customer login flow and account/orders landing page working 💥 get login check working in header/layout 💥 edit account profile to use new api 💥 edit account address to customer account api 💥 edit order details page to use customer account api 💥 get customer login flow and account/orders landing page working 💥 get login check working in header/layout 💥 edit account profile to use new api 💥 edit account address to customer account api 💥 edit order details page to use customer account api * 🗒️ Doc Changes: - add note about /account not working with mock.shop - add warming for using createCustomerClient without proper credential - add changlog * ✅ Test update - update test snapshot - Show error in tests - Fix create and build test error - Fix generating auth routes - Fix standard routes with auth - Fix setup i18n test * Update templates/skeleton/app/routes/account.$.tsx Co-authored-by: Bret Little <[email protected]> * ✨ add an option to change auth url from the default /authorize * ✨ add defer loading for login check in root (#1636) * cart edit * 🔥 remove customer-api example * Update .changeset/tasty-plums-pump.md Co-authored-by: Bret Little <[email protected]> * Update packages/hydrogen/src/customer/customer.ts Co-authored-by: Bret Little <[email protected]> * Update packages/hydrogen/src/customer/customer.ts Co-authored-by: Bret Little <[email protected]> * Update packages/hydrogen/src/customer/customer.ts Co-authored-by: Bret Little <[email protected]> * demo-store customer account api update (#1647) * ✨ move demo-store to caapi * update login button * login flow + account page * customer profile edit * address edit * cart edit * order id page * fix eslint error, strange my VS code is giving different suggestions * Update packages/hydrogen/src/customer/customer.ts Co-authored-by: Bret Little <[email protected]> * Update packages/hydrogen/src/customer/customer.ts Co-authored-by: Bret Little <[email protected]> * remove redirectPath from authorize --------- Co-authored-by: Bret Little <[email protected]> * implement redirectPath for skeleton template * use /account/authorize as the default authUrl --------- Co-authored-by: Bret Little <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
The Customer Account API will be officially release in Jan of 2024. This PR aim to replaced all current storefront API customer usage with the new API in demo-store.
WHAT is this pull request doing?
HOW to test your changes?
Post-merge steps
Checklist