-
Notifications
You must be signed in to change notification settings - Fork 288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Scaffold examples #1608
Scaffold examples #1608
Conversation
Do you have a flag here for supporting JavaScript instead of scaffolding TS? Or will that be a separate PR? Did we decide on whether we want to use the full config flow or not? Or with this command is that all a part of it (e.g. this command kicks off the config flow, but uses this to modify the skeleton) |
It feels like
Is this a decision or a constraint? Is it possible for us to change that? |
I don't think the examples are published to npm, so the only way to get them is by downloading them from Github. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Running h2 init --template express --language=js
doesn't actually produce a project in JS
It prompts if you want TS or JS, or you can pass
It uses the prompts we had for
I'm not sure I understand what you're saying. The
Both, really. This comes from the time we had
@blittle Oh, the It works with the other examples already (those with |
Depends on #1549
Adds support for scaffolding projects based on
examples
(templates
were already supported):If the example uses the
--diff
flag, then it applies it on top of theskeleton
template.Note: examples are downloaded from the latest release, not from
main
branch. Therefore, it currently only works withexpress
,multipass
orcustomer-api
until we make a new release with the new examples.