Add forwardRef to ExternalVideo and Video #1415
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
LGTM |
Contributor
|
hi @andershagbard sorry about the delay. Would you mind resolving the conflicts and try again? |
Contributor
Author
|
Had to change the type for |
wizardlyhel
approved these changes
Jan 22, 2024
Merged
juanpprieto
pushed a commit
that referenced
this pull request
Sep 17, 2025
Co-authored-by: Anders Søgaard <[email protected]> Co-authored-by: Benjamin Sehl <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
It's hard to add custom controls to video elements without having this.
WHAT is this pull request doing?
This PR adds forwardRef to Video and ExternalVideo components.
HOW to test your changes?
Use components with ref property, as the tests do.
Checklist
No docs to generate.