[cli] hydrogen deploy: Add token flag, add environment selection #1381
Conversation
This comment has been minimized.
This comment has been minimized.
vincentezw
force-pushed
the
vez/deploy-token-env-selection
branch
from
acdd4e8 to
caf480e
Compare
vincentezw
force-pushed
the
vez/deploy-token-env-selection
branch
from
caf480e to
417a63a
Compare
| @@ -36,6 +39,11 @@ export const deploymentLogger: Logger = ( | |||
|
|
|||
| export default class Deploy extends Command { | |||
| static flags: any = { | |||
| environmentTag: Flags.string({ | |||
There was a problem hiding this comment.
Just a suggestion, we are using "env" instead of "environment" in other flags, so maybe this one could be "envTag" instead or even "envBranch" like in h2 env pull?
Also, just noticed these flags are using camel case but we use kebab case for flags everywhere else. I don't think Oclif transform them internally so we should write them as kebab case here.
There was a problem hiding this comment.
I have converted all to kebab case now. Are existing flags like envBranch or other commonFlags changing too?
There was a problem hiding this comment.
Ty! The commonFlags object can use camel case because it's internal, but the flags are later exposed as kebab-case already afaik -- if we missed some flag we should change it, yeah
| environmentTag: flags['env-branch'], | ||
| path: actualPath, | ||
| shop: flags.shop, | ||
| publicDeployment: flags.publicDeployment, | ||
| publicDeployment: flags['public-deployment'], | ||
| token: flags.token, | ||
| metadataUrl: flags.metadataUrl, | ||
| metadataUser: flags.metadataUser, | ||
| metadataVersion: flags.metadataVersion, | ||
| metadataUrl: flags['metadata-url'], | ||
| metadataUser: flags['metadata-user'], | ||
| metadataVersion: flags['metadata-version'], |
There was a problem hiding this comment.
FYI you can use the flagsToCamelObject utility, it's also typed. You can see an example in commands/dev.ts and other commands
There was a problem hiding this comment.
Neat, thanks for sharing.
vincentezw
force-pushed
the
vez/deploy-token-env-selection
branch
from
f55873d to
9325faf
Compare
WHY are these changes introduced?
tokenflag to allow manual token entryoxygen-cli2.0.0 which renames the health check to "deployment verification".WHAT is this pull request doing?
This will enable merchants to use the
deploycommand in CI environments, where the automatic token retrieval through the API will not be available. Instead, they can use thetokenflag to supply an Oxygen deployment token.In addition; outside of CI environments we can display a user-friendly list of store environments to deploy to, with the current default based on the currently checked-out branch.
HOW to test your changes?
Post-merge steps
Checklist