Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix type for withCache #1363

Merged
merged 1 commit into from
Sep 25, 2023
Merged

Fix type for withCache #1363

merged 1 commit into from
Sep 25, 2023

Conversation

wizardlyhel
Copy link
Contributor

@wizardlyhel wizardlyhel commented Sep 22, 2023 •
edited
Loading

Allow generic inference in standalone usage of WithCache type

Original PR: #1192

WHY are these changes introduced?

Fixes #0000

WHAT is this pull request doing?

HOW to test your changes?

Post-merge steps

Checklist

  • I've read the Contributing Guidelines
  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've added a changeset if this PR contains user-facing or noteworthy changes
  • I've added tests to cover my changes
  • I've added or updated the documentation

@wizardlyhel wizardlyhel mentioned this pull request Sep 22, 2023
Closed
2 tasks
@wizardlyhel wizardlyhel merged commit 1be1e40 into main Sep 25, 2023
@wizardlyhel wizardlyhel deleted the fix-with-cache-type branch September 25, 2023 16:48
@shopify-github-actions-access shopify-github-actions-access bot mentioned this pull request Sep 25, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frandiox frandiox frandiox approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wizardlyhel @frandiox