Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relax prop validation on getSelectedProductOptions and getSelectedProductOptions #1327

Merged
merged 2 commits into from
Sep 14, 2023

Conversation

blittle
Copy link
Contributor

@blittle blittle commented Sep 12, 2023

WHY are these changes introduced?

The getPaginationVariables and getSelectedProductOptions utility functions validate that an argument is always an instanceof Request. While helpful, it also can be a pain when passing an object that looks exactly the same as a Request but isn't an instance of the class.

WHAT is this pull request doing?

Still validate, but instead just test if the the object contains the url property.

HOW to test your changes?

Post-merge steps

Checklist

  • I've read the Contributing Guidelines
  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've added a changeset if this PR contains user-facing or noteworthy changes
  • I've added tests to cover my changes
  • I've added or updated the documentation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant