Relax prop validation on getSelectedProductOptions
and getSelectedProductOptions
#1327
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
The
getPaginationVariables
andgetSelectedProductOptions
utility functions validate that an argument is always an instanceofRequest
. While helpful, it also can be a pain when passing an object that looks exactly the same as aRequest
but isn't an instance of the class.WHAT is this pull request doing?
Still validate, but instead just test if the the object contains the
url
property.HOW to test your changes?
Post-merge steps
Checklist