Fix cookie token generation #1294
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 31, 2023 14:46
blittle
approved these changes
Aug 31, 2023
|
|
||
| return output.padStart(8 - output.length, '0'); | ||
| // Ensure the output is exactly 8 characters | ||
| return output.padStart(8, '0'); |
Contributor
There was a problem hiding this comment.
Looks good to me, though it seems to me that whomever is consuming these values should be more defensive?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
For some reason, certain dates converted to unsigned 32-bit representation doesn't generate a string of 8 characters. This caused Shopify session analytics missing for those dates due to token resulted in an unexpected format.
WHAT is this pull request doing?
HOW to test your changes?
Post-merge steps
Checklist