Allow 404 to be caught be ErrorBoundary in Route #1215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
juanpprieto
approved these changes
Aug 11, 2023
Merged
FrcPpe
pushed a commit
to FrcPpe/hydrogen
that referenced
this pull request
Aug 13, 2023
* Allow 404 to be caught be ErrorBoundary in Route * Added a patch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Currently, (with the remix V2
v2_errorBoundaryflag) when a 404 is thrown, it is not caught by the Error boundary.WHAT is this pull request doing?
This PR adds a default exported function that returns null. This allows the ErrorBoundary in
root.tsxto catch the404errorStatus.HOW to test your changes?
localhost:3000/dsadsadsa)Checklist