Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't display errors when no storefronts exist #1053

Merged
merged 1 commit into from
Jun 28, 2023
Merged

Don't display errors when no storefronts exist #1053

merged 1 commit into from
Jun 28, 2023

Conversation

aswamy
Copy link
Contributor

@aswamy aswamy commented Jun 28, 2023

Summary

  • Remove error message when no hydrogen storefronts exist on Admin
    • Since we allow people to create a storefront on Admin from the CLI, we no longer need to throw an error when no storefronts exist on Admin

Testing

Before

image

Now

image

Post-merge steps

Checklist

  • I've read the Contributing Guidelines
  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've added a changeset if this PR contains user-facing or noteworthy changes
  • I've added tests to cover my changes
  • I've added or updated the documentation

@aswamy aswamy requested review from graygilmore and frandiox and removed request for graygilmore June 28, 2023 09:42
frandiox
frandiox approved these changes Jun 28, 2023
View reviewed changes
Copy link
Contributor

@frandiox frandiox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the quick fix!

@aswamy aswamy merged commit 850c4c9 into 2023-04 Jun 28, 2023
@aswamy aswamy deleted the link-when-no-existing-storefronts branch June 28, 2023 11:02
@aswamy aswamy removed the request for review from graygilmore June 28, 2023 11:04
@shopify-github-actions-access shopify-github-actions-access bot mentioned this pull request Jun 28, 2023
Closed
juanpprieto pushed a commit that referenced this pull request Jul 10, 2023
@aswamy @juanpprieto
Don't display errors when no storefronts exist (#1053)
2601408
@shopify-github-actions-access shopify-github-actions-access bot mentioned this pull request Jul 25, 2023
Merged
FrcPpe pushed a commit to FrcPpe/hydrogen that referenced this pull request Aug 13, 2023
@aswamy @FrcPpe
Don't display errors when no storefronts exist (Shopify#1053)
9cc7d81
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frandiox frandiox frandiox approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aswamy @frandiox