-
Notifications
You must be signed in to change notification settings - Fork 303
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add option to create storefront in h2 link
CLI command
#1013
Conversation
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Haven't had a chance to try it out but overall this is looking pretty good! We should get @gfscott and @mynameisadamf to have a look, too.
h2 link
CLI commandh2 link
CLI command
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Do we want to consider titleizing the text so if directory is named demo-storefront, the default name given is Demo Storefront?
I think that's a good idea 👍
Visually I'm not sure if these options are different enough 🤔
Not blocking tho, the visual department can wait.

Maybe more of a question for @mynameisadamf
We can apply styles on 1 single choice but I think they don't look very nice (and the number on the left doesn't change):


Force push update:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Forgot one more question: will we be handling the scenario where the app is not installed in another PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes - but i also want to discuss the flow on slack since we aren't using the create
method anymore.
NOTE: error showing when an app isn't installed is in this PR: https://github.com/Shopify/core-issues/issues/57139
WHY are these changes introduced?
h2 link
demo-storefront
will becomeDemo Storefront
. If the directory name can't be titleized, we default toHydrogen Storefront
WHAT is this pull request doing?
h2 link
tests by splitting it up between linking existing storefront vs creating and linking a new storefrontHOW to test your changes?
h2 init
with a production copy of theh2
commandpackages/cli
and runnpm i
npm run build
packages/cli
directory, runh2 link --path=/path/to/your/project
When job to create API tokens fails (this can't be resolved by the user):

Post-merge steps
Checklist