Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update powered-by header default to Shopify, Hydrogen #2518

Merged
merged 1 commit into from
May 30, 2023
Merged

Update powered-by header default to Shopify, Hydrogen #2518

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/short-frogs-obey.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@shopify/hydrogen': minor
---

Updates default `powered-by` header output to `Shopify, Hydrogen`, and updates associateed documentation.
2 changes: 1 addition & 1 deletion docs/docs/tutorials/configuration/index.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,7 @@ export default defineConfig({

### `poweredByHeader`

By default, Hydrogen responds with the `x-powered-by: Shopify-Hydrogen` header. You can disable this by adding `poweredByHeader: false` to your config:
By default, Hydrogen responds with the `powered-by: Shopify, Hydrogen` header. You can disable this by adding `poweredByHeader: false` to your config:

```tsx
// hydrogen.config.ts
Expand Down
2 changes: 1 addition & 1 deletion packages/hydrogen/src/entry-server.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,7 +136,7 @@ export const renderHydrogen = (App: any) => {

if (hydrogenConfig.poweredByHeader ?? true) {
// If undefined in the config, then always show the header
response.headers.set('powered-by', 'Shopify-Hydrogen');
response.headers.set('powered-by', 'Shopify, Hydrogen');
}

sessionApi ??= hydrogenConfig.session?.(log);
Expand Down
2 changes: 1 addition & 1 deletion packages/playground/server-components/tests/e2e-test-cases.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -274,7 +274,7 @@ export default async function testCases({

it('returns powered-by header', async () => {
const response = await fetch(getServerUrl() + '/');
expect(response.headers.get('powered-by')).toBe('Shopify-Hydrogen');
expect(response.headers.get('powered-by')).toBe('Shopify, Hydrogen');
});

it('properly escapes props in the SSR flight script chunks', async () => {
Expand Down