Skip to content

Ignore skipped tests to avoid CI noise #1432

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 6, 2022
Merged

Ignore skipped tests to avoid CI noise #1432

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/hydrogen/src/components/CartLineImage/tests/CartLineImage.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,7 @@ describe(`<CartLineImage />`, () => {
expect(wrapper).not.toContainReactComponent(Image);
});

// eslint-disable-next-line jest/expect-expect
it.skip(`typescript types`, () => {
// this test is actually just using //@ts-expect-error as the assertion, and don't need to execute in order to have TS validation on them
// I don't love this idea, but at the moment I also don't have other great ideas for how to easily test our component TS types
Expand Down
1 change: 1 addition & 0 deletions packages/hydrogen/src/components/Image/tests/Image.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -283,6 +283,7 @@ describe('<Image />', () => {
});
});

// eslint-disable-next-line jest/expect-expect
it.skip(`typescript types`, () => {
// this test is actually just using //@ts-expect-error as the assertion, and don't need to execute in order to have TS validation on them
// I don't love this idea, but at the moment I also don't have other great ideas for how to easily test our component TS types
Expand Down