Rendersize warning will not fire during active resizing #1092
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
naqvitalha
force-pushed
the
fix-render-size-warning
branch
from
e85a206 to
92b93d3
Compare
davebcn87
approved these changes
Mar 15, 2024
This was referenced Sep 9, 2024
This was referenced Sep 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
FlashList throws a warning if it mounts with very small height/width. This is useful when there is an error in parent layout however, some components might be actively resizing and this warning can still show up even when there's no real harm done by the resize. With this change, we only show the warning when the list has settled.
Also, disabled a broken test which will be enabled later.
Reviewers’ hat-rack 🎩
Screenshots or videos (if needed)
Checklist