[action needed] support RN 0.77 #1466

vonovak · 2025-01-07T12:55:28Z

Hello,
because of facebook/react-native#46809 there are changes that need to be done, similar to AppAndFlow/react-native-safe-area-context#566. This is a heads up for the maintainers.

Current behavior

build with old architecture on RN 0.77 fails with

e: file:@shopify/flash-list/android/src/main/kotlin/com/shopify/reactnative/flash_list/AutoLayoutViewManager.kt:16:74 Type argument is not within its bounds: should be subtype of 'it(BaseViewManagerInterface & com.facebook.react.viewmanagers.AutoLayoutViewManagerInterface<com.shopify.reactnative.flash_list.AutoLayoutView!>)!'.
e: file:@shopify/flash-list/android/src/main/kotlin/com/shopify/reactnative/flash_list/AutoLayoutViewManager.kt:17:39 Argument type mismatch: actual type is 'com.shopify.reactnative.flash_list.AutoLayoutViewManager', but 'U!' was expected.
e: file:@shopify/flash-list/android/src/main/kotlin/com/shopify/reactnative/flash_list/CellContainerManager.kt:13:76 Type argument is not within its bounds: should be subtype of 'it(BaseViewManagerInterface & com.facebook.react.viewmanagers.CellContainerManagerInterface<com.shopify.reactnative.flash_list.CellContainerImpl!>)!'.
e: file:@shopify/flash-list/android/src/main/kotlin/com/shopify/reactnative/flash_list/CellContainerManager.kt:14:40 Argument type mismatch: actual type is 'com.shopify.reactnative.flash_list.CellContainerManager', but 'U!' was expected.

Expected behavior

build should pass

To Reproduce

upgrade to latest RN 0.77 and build an app with flash list dep, with old arch

Platform:

iOS
Android

Environment

x.y.z

The text was updated successfully, but these errors were encountered:

tomekzaw · 2025-01-10T15:03:52Z

Here's a patch that adds support for RN 0.77: @shopify-flash-list-npm-1.7.2-2a363895ca.patch

## Summary This PR bumps `react-native` in paper-example and fabric-example from `0.76.5` to `0.77.0-rc.6` (golden RC) accordingly to https://react-native-community.github.io/upgrade-helper/?from=0.76.5&to=0.77.0-rc.6. Apart from this, changes have been made in macos-example, tvos-example and web-example to align versions of common native dependencies so they are hoisted by yarn. I had to patch `@shopify/flash-list`: * Shopify/flash-list#1466 – fixes Android build * Shopify/flash-list#1041 – fixes `scrollTo` example Changes required by Reanimated to support RN 0.77 have been moved to separate PRs for the sake of atomicity and transparency: * #6875 * #6876 * #6883 * #6884 ## Test plan --------- Co-authored-by: Krzysztof Piaskowy <[email protected]>

RohovDmytro · 2025-01-21T19:57:34Z

The patch works perfectly and today React Native 0.77.0 was released. :)

ChronoByteCosmonaut · 2025-01-22T06:16:37Z

Here's a patch that adds support for RN 0.77: @shopify-flash-list-npm-1.7.2-2a363895ca.patch

At least someone cares 🙏

efstathiosntonas · 2025-01-22T19:38:43Z

@tomekzaw thanks for the patch, I guess this is not backwards compatible for older versions of rn, correct?

tomekzaw · 2025-01-22T21:01:26Z

@efstathiosntonas To be honest I haven't checked that, I would safely assume that it's not.

vonovak · 2025-01-23T06:27:19Z

Hello, I believe that it is backward compatible (question is, down to which version?). RN SVG and others had to do the same change and they didn't do a major bump.

ssavran · 2025-01-28T08:24:42Z

Here's a patch that adds support for RN 0.77: @shopify-flash-list-npm-1.7.2-2a363895ca.patch

Steps I did so far:
1 - downloaded your patch
2 - put it under ./node_modules/@shopify/flash-list
3 - called git apply in the same folder @shopify-flash-list-npm-1.7.2-2a363895ca.patch
4 - got back into the android folder of my own project and called ./gradlew clean assembleDebug and still get an error:

Task :shopify_flash-list:compileDebugKotlin FAILED
e: file:///Users/sercansametsavran/Documents/Viveel/ViveelProject/Viveelupdate/Viveel/node_modules/@shopify/flash-list/android/src/main/kotlin/com/shopify/reactnative/flash_list/AutoLayoutViewManager.kt:16:74 Type argument is not within its bounds: should be subtype of 'it(BaseViewManagerInterface & com.facebook.react.viewmanagers.AutoLayoutViewManagerInterface<com.shopify.reactnative.flash_list.AutoLayoutView!>)!'.
e: file:///Users/sercansametsavran/Documents/Viveel/ViveelProject/Viveelupdate/Viveel/node_modules/@shopify/flash-list/android/src/main/kotlin/com/shopify/reactnative/flash_list/AutoLayoutViewManager.kt:17:39 Argument type mismatch: actual type is 'com.shopify.reactnative.flash_list.AutoLayoutViewManager', but 'U!' was expected.
e: file:///Users/sercansametsavran/Documents/Viveel/ViveelProject/Viveelupdate/Viveel/node_modules/@shopify/flash-list/android/src/main/kotlin/com/shopify/reactnative/flash_list/CellContainerManager.kt:13:76 Type argument is not within its bounds: should be subtype of 'it(BaseViewManagerInterface & com.facebook.react.viewmanagers.CellContainerManagerInterface<com.shopify.reactnative.flash_list.CellContainerImpl!>)!'.
e: file:///Users/sercansametsavran/Documents/Viveel/ViveelProject/Viveelupdate/Viveel/node_modules/@shopify/flash-list/android/src/main/kotlin/com/shopify/reactnative/flash_list/CellContainerManager.kt:14:40 Argument type mismatch: actual type is 'com.shopify.reactnative.flash_list.CellContainerManager', but 'U!' was expected.

Any ideas, what might went wrong in my case?

EDIT: I think your patch was just for the java classes and in my case the kotlin classes have the errors...

MaxTheTurtle0 · 2025-01-28T18:40:01Z

Here's a patch that adds support for RN 0.77: @shopify-flash-list-npm-1.7.2-2a363895ca.patch

Steps I did so far: 1 - downloaded your patch 2 - put it under ./node_modules/@shopify/flash-list 3 - called git apply in the same folder @shopify-flash-list-npm-1.7.2-2a363895ca.patch 4 - got back into the android folder of my own project and called ./gradlew clean assembleDebug and still get an error:

Task :shopify_flash-list:compileDebugKotlin FAILED
e: file:///Users/sercansametsavran/Documents/Viveel/ViveelProject/Viveelupdate/Viveel/node_modules/@shopify/flash-list/android/src/main/kotlin/com/shopify/reactnative/flash_list/AutoLayoutViewManager.kt:16:74 Type argument is not within its bounds: should be subtype of 'it(BaseViewManagerInterface & com.facebook.react.viewmanagers.AutoLayoutViewManagerInterface<com.shopify.reactnative.flash_list.AutoLayoutView!>)!'.
e: file:///Users/sercansametsavran/Documents/Viveel/ViveelProject/Viveelupdate/Viveel/node_modules/@shopify/flash-list/android/src/main/kotlin/com/shopify/reactnative/flash_list/AutoLayoutViewManager.kt:17:39 Argument type mismatch: actual type is 'com.shopify.reactnative.flash_list.AutoLayoutViewManager', but 'U!' was expected.
e: file:///Users/sercansametsavran/Documents/Viveel/ViveelProject/Viveelupdate/Viveel/node_modules/@shopify/flash-list/android/src/main/kotlin/com/shopify/reactnative/flash_list/CellContainerManager.kt:13:76 Type argument is not within its bounds: should be subtype of 'it(BaseViewManagerInterface & com.facebook.react.viewmanagers.CellContainerManagerInterface<com.shopify.reactnative.flash_list.CellContainerImpl!>)!'.
e: file:///Users/sercansametsavran/Documents/Viveel/ViveelProject/Viveelupdate/Viveel/node_modules/@shopify/flash-list/android/src/main/kotlin/com/shopify/reactnative/flash_list/CellContainerManager.kt:14:40 Argument type mismatch: actual type is 'com.shopify.reactnative.flash_list.CellContainerManager', but 'U!' was expected.

Any ideas, what might went wrong in my case?

EDIT: I think your patch was just for the java classes and in my case the kotlin classes have the errors...

I am getting the same error

This PR bumps `react-native` in paper-example and fabric-example from `0.76.5` to `0.77.0-rc.6` (golden RC) accordingly to https://react-native-community.github.io/upgrade-helper/?from=0.76.5&to=0.77.0-rc.6. Apart from this, changes have been made in macos-example, tvos-example and web-example to align versions of common native dependencies so they are hoisted by yarn. I had to patch `@shopify/flash-list`: * Shopify/flash-list#1466 – fixes Android build * Shopify/flash-list#1041 – fixes `scrollTo` example Changes required by Reanimated to support RN 0.77 have been moved to separate PRs for the sake of atomicity and transparency: * #6875 * #6876 * #6883 * #6884 --------- Co-authored-by: Krzysztof Piaskowy <[email protected]>

vonovak added the bug Something isn't working label Jan 7, 2025

tomekzaw mentioned this issue Jan 10, 2025

Bump example apps to React Native 0.77 software-mansion/react-native-reanimated#6768

Merged

huextrat mentioned this issue Jan 22, 2025

fix(android): support RN 0.77 #1484

Merged

1 task

naqvitalha closed this as completed in #1484 Jan 28, 2025

stage88 mentioned this issue Feb 19, 2025

[🐛] Android - build fail on react-native 0.77 invertase/react-native-google-mobile-ads#701

Open

1 task

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[action needed] support RN 0.77 #1466

[action needed] support RN 0.77 #1466

vonovak commented Jan 7, 2025 •

edited

Loading

tomekzaw commented Jan 10, 2025

RohovDmytro commented Jan 21, 2025 •

edited

Loading

ChronoByteCosmonaut commented Jan 22, 2025

efstathiosntonas commented Jan 22, 2025

tomekzaw commented Jan 22, 2025

vonovak commented Jan 23, 2025

ssavran commented Jan 28, 2025 •

edited

Loading

MaxTheTurtle0 commented Jan 28, 2025

[action needed] support RN 0.77 #1466

[action needed] support RN 0.77 #1466

Comments

vonovak commented Jan 7, 2025 • edited Loading

Current behavior

Expected behavior

To Reproduce

Platform:

Environment

tomekzaw commented Jan 10, 2025

RohovDmytro commented Jan 21, 2025 • edited Loading

ChronoByteCosmonaut commented Jan 22, 2025

efstathiosntonas commented Jan 22, 2025

tomekzaw commented Jan 22, 2025

vonovak commented Jan 23, 2025

ssavran commented Jan 28, 2025 • edited Loading

MaxTheTurtle0 commented Jan 28, 2025

vonovak commented Jan 7, 2025 •

edited

Loading

RohovDmytro commented Jan 21, 2025 •

edited

Loading

ssavran commented Jan 28, 2025 •

edited

Loading