Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Themes] Do not merge - Add logs around password logic #4832

Closed
wants to merge 1 commit into from

Conversation

frandiox
Copy link
Contributor

WHY are these changes introduced?

This should not be merged. Related to #4733

WHAT is this pull request doing?

This PR adds logs around the password logic to see if the user environment fails to get the password from the prompt.

How to test your changes?

Post-release steps

Measuring impact

How do we know this change was effective? Please choose one:

  • n/a - this doesn't need measurement, e.g. a linting rule or a bug-fix
  • Existing analytics will cater for this addition
  • PR includes analytics changes to measure impact

Checklist

  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've considered possible documentation changes

@frandiox
Copy link
Contributor Author

/snapit

Copy link
Contributor

🫰✨ Thanks @frandiox! Your snapshot has been published to npm.

Test the snapshot by intalling your package globally:

pnpm i -g @shopify/[email protected]

After installing, validate the version by running just shopify in your terminal
If the versions don't match, you might have multiple global instances installed.
Use which shopify to find out which one you are running and uninstall it.

Copy link
Contributor

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements
71.78% (+0.01% 🔼)
8459/11784
🟡 Branches
68.24% (+0.02% 🔼)
4104/6014
🟡 Functions 71.31% 2220/3113
🟡 Lines
72.25% (+0.01% 🔼)
8000/11073

Test suite run success

1917 tests passing in 870 suites.

Report generated by 🧪jest coverage report action from c1740d6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant