Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run AppWatcher as a dev process #4828

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Conversation

isaacroldan
Copy link
Contributor

WHY are these changes introduced?

We want to use the AppWatcher globally by all the other processes, this way any process can subscribe to app changes during dev.

WHAT is this pull request doing?

  • Create a new AppWatcherProcess that starts the App Watcher
  • Inject the shared AppWatcher to DevSessionProcess
  • Expose the BuildResult in each extension event -> To know if the extension was successfully built after the detected change.
  • Do some cleanup and update tests

How to test your changes?

Run app dev with the app management API.

Post-release steps

Measuring impact

How do we know this change was effective? Please choose one:

  • n/a - this doesn't need measurement, e.g. a linting rule or a bug-fix
  • Existing analytics will cater for this addition
  • PR includes analytics changes to measure impact

Checklist

  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've considered possible documentation changes

@isaacroldan isaacroldan requested a review from a team as a code owner November 11, 2024 16:30
Copy link
Contributor

We detected some changes at packages/*/src and there are no updates in the .changeset.
If the changes are user-facing, run "pnpm changeset add" to track your changes and include them in the next release CHANGELOG.

Copy link
Contributor

github-actions bot commented Nov 11, 2024

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements
71.41% (+0.1% 🔼)
8476/11869
🟡 Branches
68.03% (+0.17% 🔼)
4116/6050
🟡 Functions
70.91% (+0.01% 🔼)
2223/3135
🟡 Lines
71.83% (+0.08% 🔼)
8015/11158
Show new covered files 🐣
St.
File Statements Branches Functions Lines
🔴
... / app-watcher-process.ts
50% 100% 50% 50%
Show files with reduced coverage 🔻
St.
File Statements Branches Functions Lines
🟢
... / app-watcher-esbuild.ts
82.76% (-7.56% 🔻)
100%
78.57% (-6.04% 🔻)
85.19% (-7.92% 🔻)

Test suite run success

1917 tests passing in 870 suites.

Report generated by 🧪jest coverage report action from 1ec6c6c

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant