-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support migrating subscription link extension #4788
Conversation
Differences in type declarationsWe detected differences in the type declarations generated by Typescript for this branch compared to the baseline ('main' branch). Please, review them to ensure they are backward-compatible. Here are some important things to keep in mind:
New type declarationsWe found no new type declarations in this PR Existing type declarationspackages/cli-kit/dist/public/node/themes/api.d.ts@@ -5,7 +5,7 @@ export type AssetParams = Pick<ThemeAsset, 'key'> & Partial<Pick<ThemeAsset, 'va
export declare function fetchTheme(id: number, session: AdminSession): Promise<Theme | undefined>;
export declare function fetchThemes(session: AdminSession): Promise<Theme[]>;
export declare function createTheme(params: ThemeParams, session: AdminSession): Promise<Theme | undefined>;
-export declare function fetchThemeAssets(id: number, filenames: Key[], session: AdminSession): Promise<ThemeAsset[]>;
+export declare function fetchThemeAsset(id: number, key: Key, session: AdminSession): Promise<ThemeAsset | undefined>;
export declare function deleteThemeAsset(id: number, key: Key, session: AdminSession): Promise<boolean>;
export declare function bulkUploadThemeAssets(id: number, assets: AssetParams[], session: AdminSession): Promise<Result[]>;
export declare function fetchChecksums(id: number, session: AdminSession): Promise<Checksum[]>;
|
Coverage report
Show new covered files 🐣
Show files with reduced coverage 🔻
Test suite run success1914 tests passing in 870 suites. Report generated by 🧪jest coverage report action from 574019d |
8a4f30d
to
bbd6984
Compare
We detected some changes at packages/*/src and there are no updates in the .changeset. |
bbd6984
to
574019d
Compare
WHY are these changes introduced?
Closes: https://github.com/Shopify/subscriptions-app-remix/issues/2062
Rebased off of: #4758
Should be merged after: #4787
WHAT is this pull request doing?
Supports migrating dashboard-managed subscription link extensions to become CLI managed as part of the
dev
anddeploy
commands.How to test your changes?
Follow the steps described in #4787 to import subscription link extensions to CLI. Once imported run
shopify app dev
orshopify app deploy
to migrate the extension to be CLI managed.Post-release steps
Measuring impact
How do we know this change was effective? Please choose one:
Checklist