New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix UID matching issues #4777

Draft

gordonhirsch wants to merge 3 commits into main from uid-matching-fixes

Contributor

gordonhirsch commented Oct 30, 2024

WHY are these changes introduced?

Fixes #0000

WHAT is this pull request doing?

How to test your changes?

Post-release steps

Measuring impact

How do we know this change was effective? Please choose one:

n/a - this doesn't need measurement, e.g. a linting rule or a bug-fix
Existing analytics will cater for this addition
PR includes analytics changes to measure impact

Checklist

I've considered possible cross-platform impacts (Mac, Linux, Windows)
I've considered possible documentation changes


          get module uid from user_identifier field

bcdb4f0

Contributor

github-actions bot commented Oct 30, 2024 •

edited

Loading

Coverage report

St.^❔	Category	Percentage	Covered / Total
🟡	Statements	72.06% (+0.01% 🔼)	8356/11596
🟡	Branches	68.51% (+0.02% 🔼)	4042/5900
🟡	Functions	71.33%	2192/3073
🟡	Lines	72.44% (+0.01% 🔼)	7902/10908

Test suite run success

1893 tests passing in 867 suites.

Report generated by 🧪jest coverage report action from 3d5fdfd

gonzaloriestra added 2 commits

November 8, 2024 13:08


          Fix type-check

7cbc251


          Merge branch 'main' into uid-matching-fixes

3d5fdfd

gonzaloriestra approved these changes

View reviewed changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet