-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add import admin link extensions to CLI and migration on deployment #4738
base: main
Are you sure you want to change the base?
Conversation
We detected some changes at packages/*/src and there are no updates in the .changeset. |
e211bdb
to
3064b2a
Compare
Coverage report
Show new covered files 🐣
Show files with reduced coverage 🔻
Test suite run success1921 tests passing in 874 suites. Report generated by 🧪jest coverage report action from aa75f67 |
3064b2a
to
a7c07e9
Compare
{ | ||
label: 'Admin Link extensions', | ||
value: 'link extension', | ||
extensionTypes: ['app_link', 'bulk_action'], | ||
buildTomlObject: buildAdminLinkTomlObject, | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only for shopifolk
? is that intended?
@@ -45,6 +46,11 @@ export async function ensureExtensionsIds( | |||
dashboardOnlyExtensions, | |||
validIdentifiers, | |||
) | |||
const adminLinkExtensionsToMigrate = getAdminLinkExtensionsToMigrate( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I noticed that all get**ExtensionsToMigrate
functions do mostly the same, do you want to unify that in a generic function? :)
We can leave it for a future PR if not
a9d372c
to
9848bad
Compare
9848bad
to
2da0ee9
Compare
2da0ee9
to
aa75f67
Compare
NOTE: Do not merge until BE work lands
WHY are these changes introduced?
With the removal of the Partners Dashboard it is needed to migrate all dashboard managed extensions to be CLI managed. This PR adds support to import existing admin links (
app_link
and `bulk_action) and the call to the appModules migration endpoint on their deployment to update them to a CLI managed specification.How to test your changes?
pnpm shopify app import-extensions --path path/to/your/app
Checklist