Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.68] Avoid process exit when failing to delete a file from the remote theme #4614

Merged
merged 1 commit into from
Oct 10, 2024

Conversation

karreiro
Copy link
Contributor

@karreiro karreiro commented Oct 9, 2024

Backport #4581

Copy link
Contributor

github-actions bot commented Oct 9, 2024

Thanks for your contribution!

Depending on what you are working on, you may want to request a review from a Shopify team:

  • Themes: @shopify/advanced-edits
  • UI extensions: @shopify/ui-extensions-cli
    • Checkout UI extensions: @shopify/checkout-ui-extensions-api-stewardship
  • Hydrogen: @shopify/hydrogen
  • Other: @shopify/app-inner-loop

Copy link
Contributor

github-actions bot commented Oct 9, 2024

Differences in type declarations

We detected differences in the type declarations generated by Typescript for this branch compared to the baseline ('main' branch). Please, review them to ensure they are backward-compatible. Here are some important things to keep in mind:

  • Some seemingly private modules might be re-exported through public modules.
  • If the branch is behind main you might see odd diffs, rebase main into this branch.

New type declarations

We found no new type declarations in this PR

Existing type declarations

packages/cli-kit/dist/public/node/fs.d.ts
@@ -283,7 +283,6 @@ export declare function pathToFileURL(path: string): URL;
 export declare function findPathUp(matcher: OverloadParameters<typeof internalFindUp>[0], options: OverloadParameters<typeof internalFindUp>[1]): ReturnType<typeof internalFindUp>;
 export interface MatchGlobOptions {
     matchBase: boolean;
-    noglobstar: boolean;
 }
 /**
  * Matches a key against a glob pattern.

Copy link
Contributor

github-actions bot commented Oct 9, 2024

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements 72.61% 8522/11737
🟡 Branches 69.54% 4178/6008
🟡 Functions 71.61% 2205/3079
🟡 Lines 72.92% 8064/11058

Test suite run success

1939 tests passing in 873 suites.

Report generated by 🧪jest coverage report action from 7033292

@karreiro karreiro requested review from frandiox and a team October 9, 2024 09:22
@karreiro karreiro changed the title [3.68] Avoid process exit when failing to delete a file from the remo… [3.68] Avoid process exit when failing to delete a file from the remote theme Oct 9, 2024
@karreiro karreiro merged commit 5daa2ed into stable/3.68 Oct 10, 2024
37 checks passed
@karreiro karreiro deleted the 4581-backport branch October 10, 2024 06:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants