Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[3.68] Update the ignore module (--only/--ignore/.shopifyignore) to be backward compatible with (Ruby) Shopify CLI 2 #4611

Merged
merged 1 commit into from
Oct 10, 2024
Merged

[3.68] Update the ignore module (--only/--ignore/.shopifyignore) to be backward compatible with (Ruby) Shopify CLI 2 #4611

merged 1 commit into from
Oct 10, 2024

Conversation

karreiro
Copy link
Contributor

@karreiro karreiro commented Oct 9, 2024

Backport #4564

@karreiro
[3.68] Update the ignore module (--only/--ignore/.shopifyignore…
cbcb436 
…) to be backward compatible with (Ruby) Shopify CLI 2
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 9, 2024

Thanks for your contribution!

Depending on what you are working on, you may want to request a review from a Shopify team:

  • Themes: @shopify/advanced-edits
  • UI extensions: @shopify/ui-extensions-cli
    • Checkout UI extensions: @shopify/checkout-ui-extensions-api-stewardship
  • Hydrogen: @shopify/hydrogen
  • Other: @shopify/app-inner-loop

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 9, 2024

Coverage report

St.❔
 Category Percentage Covered / Total
🟡 Statements 72.61% 8522/11737
🟡 Branches 69.55% 4178/6007
🟡 Functions 71.61% 2205/3079
🟡 Lines 72.92% 8064/11058

Test suite run success

1939 tests passing in 873 suites.

Report generated by 🧪jest coverage report action from cbcb436

@karreiro karreiro requested review from frandiox, jamesmengo and a team and removed request for frandiox October 9, 2024 09:21
@karreiro karreiro merged commit 7f6d271 into stable/3.68 Oct 10, 2024
37 checks passed
@karreiro karreiro deleted the 4564-backport branch October 10, 2024 06:20
@WontonSam WontonSam mentioned this pull request Nov 4, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EvilGenius13 EvilGenius13 EvilGenius13 approved these changes

@jamesmengo jamesmengo jamesmengo approved these changes

@frandiox frandiox frandiox approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@karreiro @frandiox @jamesmengo @EvilGenius13