Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix shopify theme pull --only <value> so it does not delete ignored files #4563

Merged
merged 1 commit into from
Oct 4, 2024

Conversation

karreiro
Copy link
Contributor

@karreiro karreiro commented Oct 2, 2024

WHY are these changes introduced?

Fixes #4472

WHAT is this pull request doing?

This updates the shopify theme pull command to ignore files as expected by applying the ignore filters in the local keys.

How to test your changes?

  • Run shopify theme init test
  • Run cd test
  • Run rm locales/es*
  • Run shopify theme push -d
  • Run git checkout locales/
  • Run shopify theme pull -d --only config
  • Notice that locales/es.json and locales/es.schema.json are no longer deleted

Post-release steps

N/A

Measuring impact

How do we know this change was effective? Please choose one:

  • n/a - this doesn't need measurement, e.g. a linting rule or a bug-fix
  • Existing analytics will cater for this addition
  • PR includes analytics changes to measure impact

Checklist

  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've considered possible documentation changes

Copy link
Contributor

github-actions bot commented Oct 2, 2024

Thanks for your contribution!

Depending on what you are working on, you may want to request a review from a Shopify team:

  • Themes: @shopify/advanced-edits
  • UI extensions: @shopify/ui-extensions-cli
    • Checkout UI extensions: @shopify/checkout-ui-extensions-api-stewardship
  • Hydrogen: @shopify/hydrogen
  • Other: @shopify/app-inner-loop

Copy link
Contributor

github-actions bot commented Oct 2, 2024

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements 72.6% 8521/11737
🟡 Branches 69.52% 4177/6008
🟡 Functions 71.61% 2205/3079
🟡 Lines 72.92% 8063/11058
Show files with reduced coverage 🔻
St.
File Statements Branches Functions Lines
🟢
... / ConcurrentOutput.tsx
98.39% (-1.61% 🔻)
90.91% (-4.55% 🔻)
100%
98.33% (-1.67% 🔻)

Test suite run success

1939 tests passing in 873 suites.

Report generated by 🧪jest coverage report action from 51178f2

@karreiro karreiro requested review from frandiox, jamesmengo and a team October 2, 2024 08:16
Copy link
Contributor

@frandiox frandiox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@karreiro karreiro added the #gsd:40767 Fortify local development experience for Liquid themes label Oct 2, 2024
Copy link
Contributor

@jamesmengo jamesmengo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎩 + code LGTM! Thank you :)

@karreiro karreiro added this pull request to the merge queue Oct 3, 2024
github-merge-queue bot pushed a commit that referenced this pull request Oct 3, 2024
Fix `shopify theme pull --only <value>` so it does not delete ignored files
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 3, 2024
@karreiro karreiro added this pull request to the merge queue Oct 4, 2024
Merged via the queue into main with commit 36a4061 Oct 4, 2024
37 checks passed
@karreiro karreiro deleted the fix-4472 branch October 4, 2024 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
#gsd:40767 Fortify local development experience for Liquid themes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: theme pull --only Removing Files
3 participants