-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix shopify theme pull --only <value>
so it does not delete ignored files
#4563
Conversation
Thanks for your contribution! Depending on what you are working on, you may want to request a review from a Shopify team:
|
Coverage report
Show files with reduced coverage 🔻
Test suite run success1939 tests passing in 873 suites. Report generated by 🧪jest coverage report action from 51178f2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎩 + code LGTM! Thank you :)
Fix `shopify theme pull --only <value>` so it does not delete ignored files
WHY are these changes introduced?
Fixes #4472
WHAT is this pull request doing?
This updates the
shopify theme pull
command to ignore files as expected by applying the ignore filters in the local keys.How to test your changes?
shopify theme init test
cd test
rm locales/es*
shopify theme push -d
git checkout locales/
shopify theme pull -d --only config
locales/es.json
andlocales/es.schema.json
are no longer deletedPost-release steps
N/A
Measuring impact
How do we know this change was effective? Please choose one:
Checklist