-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add restriction to only allow one customer account page render per extension #4489
Conversation
Thanks for your contribution! Depending on what you are working on, you may want to request a review from a Shopify team:
|
Coverage report
Show files with reduced coverage 🔻
Test suite run success1890 tests passing in 857 suites. Report generated by 🧪jest coverage report action from 0022560 |
This comment has been minimized.
This comment has been minimized.
f8780d0
to
27aad0d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
We may also need the gating on the BED. Since if devs using earlier version cli, the error message is not shown.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM in general. Left one comment around wording, but code looks good otherwise. Also, you may want to get someone from the CLI team to 👀 this PR as well just to make sure they're aligned with the change.
🎩 ✅
31dc17f
to
0022560
Compare
I think @Shopify/app-ui might be the team to ping on this? You can also drop into #help-cli and ask for a review there. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@brianshen1990, the CLI is trying to move away as much as possible from extension specific logic like this (correct me if wrong @isaacroldan ). And, as mentioned by @lihaokx, having the validation in the CLI only applies to developers running the release with this changes.
IMO this validation should live in the BE, specifically in the group definition. The requires
property allows to define a list of targets valid to be deployed with the current one and it can be easily extended to define a list of targets which it can not coexist.
FYI @vividviolet
WHY are these changes introduced?
Post-release steps
Measuring impact
How do we know this change was effective? Please choose one:
Checklist