Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Javy to 3.1.1 #4481

Merged
merged 2 commits into from
Sep 19, 2024
Merged

Bump Javy to 3.1.1 #4481

merged 2 commits into from
Sep 19, 2024

Conversation

andrewhassan
Copy link
Contributor

WHY are these changes introduced?

Javy 3.1.1 contains a fix for source-compression, which ensures that the JS source gets compressed correctly.

WHAT is this pull request doing?

This PR bumps the Javy version to 3.1.1

How to test your changes?

  1. Clean all artifacts locally: p clean
  2. Validate there's no Javy binary at packages/app/dist/cli/services/bin/javy
  3. Build a JS function: p run shopify app function build --path {pathToFunction} --verbose

Ensure:

  • Build was successful
  • packages/app/dist/cli/services/bin/javy --version outputs 3.1.1
  • Running the function works

Measuring impact

How do we know this change was effective? Please choose one:

  • n/a - this doesn't need measurement, e.g. a linting rule or a bug-fix
  • Existing analytics will cater for this addition
  • PR includes analytics changes to measure impact

Checklist

  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've considered possible documentation changes

This comment has been minimized.

Copy link
Contributor

github-actions bot commented Sep 19, 2024

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements
73.02% (+0.02% 🔼)
8390/11490
🟡 Branches
69.58% (+0.03% 🔼)
4092/5881
🟡 Functions 71.75% 2179/3037
🟡 Lines
73.37% (+0.02% 🔼)
7939/10821

Test suite run success

1889 tests passing in 857 suites.

Report generated by 🧪jest coverage report action from 5548552

@andrewhassan andrewhassan added this pull request to the merge queue Sep 19, 2024
@andrewhassan andrewhassan mentioned this pull request Sep 19, 2024
@andrewhassan andrewhassan removed this pull request from the merge queue due to a manual request Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants