Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dev after app creation with App Management API #4478

Merged
merged 1 commit into from
Sep 19, 2024

Conversation

gonzaloriestra
Copy link
Contributor

WHY are these changes introduced?

The CLI was using the wrong API client after creating an app in a Business Platform organization.

WHAT is this pull request doing?

Select the developer platform client from the configuration instead of using the default one.

How to test your changes?

  • p shopify app init
  • USE_APP_MANAGEMENT_API=1 p shopify app dev => create a new app

Measuring impact

How do we know this change was effective? Please choose one:

  • n/a - this doesn't need measurement, e.g. a linting rule or a bug-fix
  • Existing analytics will cater for this addition
  • PR includes analytics changes to measure impact

Checklist

  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've considered possible documentation changes

Copy link
Contributor

Thanks for your contribution!

Depending on what you are working on, you may want to request a review from a Shopify team:

  • Themes: @shopify/advanced-edits
  • UI extensions: @shopify/ui-extensions-cli
    • Checkout UI extensions: @shopify/checkout-ui-extensions-api-stewardship
  • Hydrogen: @shopify/hydrogen
  • Other: @shopify/app-inner-loop

Copy link
Contributor

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements
73.01% (+0.01% 🔼)
8390/11491
🟡 Branches
69.58% (+0.02% 🔼)
4092/5881
🟡 Functions 71.75% 2179/3037
🟡 Lines
73.36% (+0.01% 🔼)
7939/10822
Show files with reduced coverage 🔻
St.
File Statements Branches Functions Lines
🟢
... / info.ts
90.09% (-0.09% 🔻)
75% 93.33%
92.16% (-0.08% 🔻)

Test suite run success

1889 tests passing in 857 suites.

Report generated by 🧪jest coverage report action from b0cbaf5

@gonzaloriestra gonzaloriestra marked this pull request as ready for review September 19, 2024 09:14
Copy link
Contributor

We detected some changes at either packages/*/src or packages/cli-kit/assets/cli-ruby/** and there are no updates in the .changeset.
If the changes are user-facing, run "pnpm changeset add" to track your changes and include them in the next release CHANGELOG.

@gonzaloriestra gonzaloriestra added this pull request to the merge queue Sep 19, 2024
Merged via the queue into main with commit cd65687 Sep 19, 2024
37 checks passed
@gonzaloriestra gonzaloriestra deleted the fix-api-client-switch-on-dev branch September 19, 2024 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants