Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Functions] Bump javy #4437

Conversation

saulecabrera
Copy link
Member

@saulecabrera saulecabrera commented Sep 11, 2024

WHY are these changes introduced?

This commit updates the following versions:

  • javy: 3.0.1 -> 3.1.0

The only functional change introduced as part of this PR is changing the invocation of javy, which includes the new option groups, introduced in version 3.1.0.

How to test your changes?

  • Create a new JavaScript extension
  • Build it
  • Test it with function runner
  • Inspect the generated Wasm binary, it should include exports under the namespace: javy_quickjs_provider_v3

Checklist

  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've considered possible documentation changes

@saulecabrera saulecabrera changed the title Bump javy and function-runner [Functions] Bump javy and function-runner Sep 11, 2024
@saulecabrera saulecabrera force-pushed the update-javy-and-function-runner branch 7 times, most recently from f284e9c to fb2c99c Compare September 12, 2024 16:16
@saulecabrera saulecabrera changed the title [Functions] Bump javy and function-runner [Functions] Bump javy Sep 12, 2024
@saulecabrera saulecabrera marked this pull request as ready for review September 12, 2024 16:22
@saulecabrera
Copy link
Member Author

@andrewhassan / @DuncanUszkay1 I think this is ready for a review and 🎩 . I'm still figuring out why the tests are failing, on a first skim, failures seem unrelated, unless I'm missing something, so if you have any tips, I'd love to hear them.

@saulecabrera
Copy link
Member Author

Oh actually one of them is related, taking a look.

This commit updates the following versions:

* `javy`: 3.0.1 -> 3.1.0
const FUNCTION_RUNNER_VERSION = 'v6.2.0'
const JAVY_VERSION = 'v3.1.0'
Copy link
Contributor

@DuncanUszkay1 DuncanUszkay1 Sep 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤔 it's not clear to me from scanning this file what the upgrade process is here- it seems that as long as there's a javy executable in the bin, this version won't get downloaded when installBinary is called. Is that the intention?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah it is: in our previous model, javy would be automatically downloaded making the relationship between javy and cli versions 1:N; in our new model however, such relationship is switched to 1:1. A new CLI version doesn't pre-populate the bin directory, which means that when running the build or run commands for the first time the given javy version will be downloaded.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So to answer your question more concretely, there's no automatic upgrade process, a javy version bump is tied to a cli version bump.

@saulecabrera
Copy link
Member Author

I'll have to close/re-open this PR, it seems that some of the CI scripts don't work as expected in forks. I'll switch to a branch instead.

@saulecabrera
Copy link
Member Author

Opened #4444 instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants