Avoid link on deploy when there is a current config #4387
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! Depending on what you are working on, you may want to request a review from a Shopify team:
|
Coverage report
Test suite run success1860 tests passing in 845 suites. Report generated by 🧪jest coverage report action from a8c08f2 |
shauns
approved these changes
Aug 28, 2024
This was referenced Aug 28, 2024
This was referenced Sep 26, 2024
This was referenced Oct 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Fixes https://github.com/Shopify/develop-app-inner-loop/issues/2048
Fixes #4264
In v3.65 we included this refactor that allowed to run link from the deploy command, but there are some situations where we are running link, but we shouldn't because we should use a current configuration. This is affecting especially in CI environments because the link process produces an error as it requires an input by the user.
WHAT is this pull request doing?
Only run link on deploy when:
How to test your changes?
p shopify app deployp shopify app deploy --client-id whateverp shopify app deploy -c productionp shopify app config use productionp shopify app deployp shopify app deploy --resetMeasuring impact
How do we know this change was effective? Please choose one:
Checklist