Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support hyperlinks in Windows Terminal by default #4363

Merged
merged 2 commits into from
Sep 5, 2024

Conversation

nickwesselman
Copy link
Contributor

@nickwesselman nickwesselman commented Aug 21, 2024

Use the latest supports-hyperlinks package, which now enables hyperlinks for Windows Terminal by default.

We need to add it to resolutions as well given the transitive dependency in terminal-link.

How to test your changes?

Tested on Windows and MacOS

Measuring impact

How do we know this change was effective? Please choose one:

  • [] n/a - this doesn't need measurement, e.g. a linting rule or a bug-fix
  • Existing analytics will cater for this addition
  • PR includes analytics changes to measure impact

Checklist

  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've considered possible documentation changes

@nickwesselman
Copy link
Contributor Author

/snapit

Copy link
Contributor

🫰✨ Thanks @nickwesselman! Your snapshot has been published to npm.

Test the snapshot by intalling your package globally:

pnpm i -g @shopify/[email protected]

After installing, validate the version by running just shopify in your terminal
If the versions don't match, you might have multiple global instances installed.
Use which shopify to find out which one you are running and uninstall it.

Copy link
Contributor

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements
72.78% (+0.1% 🔼)
8225/11301
🟡 Branches
69.48% (+0.03% 🔼)
4006/5766
🟡 Functions
71.52% (+0.03% 🔼)
2150/3006
🟡 Lines
73.13% (+0.1% 🔼)
7781/10640
Show files with reduced coverage 🔻
St.
File Statements Branches Functions Lines
🟢
... / ConcurrentOutput.tsx
98.39% (-1.61% 🔻)
90.91% (-4.55% 🔻)
100%
98.33% (-1.67% 🔻)

Test suite run success

1856 tests passing in 846 suites.

Report generated by 🧪jest coverage report action from 21efcd3

@nickwesselman nickwesselman marked this pull request as ready for review August 21, 2024 20:31
Copy link
Contributor

@gonzaloriestra gonzaloriestra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants