Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix duplicated slashes when deploying webhooks with relative URIs #4357

Merged
merged 2 commits into from
Aug 21, 2024

Conversation

gonzaloriestra
Copy link
Contributor

WHY are these changes introduced?

Related to #4298 (comment)

WHAT is this pull request doing?

When you deploy an app with:

  • Application URL including a final slash (default value in the template), like https://example.com/
  • Webhook with a relative URI, like /webhooks

Then the webhook is registered with a duplicated slash in Partners: https://example.com//webhooks

How to test your changes?

  • p shopify app deploy

Measuring impact

How do we know this change was effective? Please choose one:

  • n/a - this doesn't need measurement, e.g. a linting rule or a bug-fix
  • Existing analytics will cater for this addition
  • PR includes analytics changes to measure impact

Checklist

  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've considered possible documentation changes

Copy link
Contributor

Thanks for your contribution!

Depending on what you are working on, you may want to request a review from a Shopify team:

  • Themes: @shopify/advanced-edits
  • UI extensions: @shopify/ui-extensions-cli
    • Checkout UI extensions: @shopify/checkout-ui-extensions-api-stewardship
  • Hydrogen: @shopify/hydrogen
  • Other: @shopify/app-inner-loop

@gonzaloriestra
Copy link
Contributor Author

/snapit

Copy link
Contributor

🫰✨ Thanks @gonzaloriestra! Your snapshot has been published to npm.

Test the snapshot by intalling your package globally:

pnpm i -g @shopify/[email protected]

After installing, validate the version by running just shopify in your terminal
If the versions don't match, you might have multiple global instances installed.
Use which shopify to find out which one you are running and uninstall it.

@gonzaloriestra gonzaloriestra marked this pull request as ready for review August 21, 2024 09:51
Copy link
Contributor

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements
73.28% (+0.12% 🔼)
8210/11203
🟡 Branches
69.66% (+0.07% 🔼)
3991/5729
🟡 Functions
71.85% (+0.03% 🔼)
2149/2991
🟡 Lines
73.61% (+0.12% 🔼)
7765/10549

Test suite run success

1854 tests passing in 846 suites.

Report generated by 🧪jest coverage report action from 97aade1

@gonzaloriestra gonzaloriestra added this pull request to the merge queue Aug 21, 2024
Merged via the queue into main with commit a85a891 Aug 21, 2024
38 checks passed
@gonzaloriestra gonzaloriestra deleted the fix-duplicated-slash-webhook-uri branch August 21, 2024 13:36
@gonzaloriestra gonzaloriestra added the #gsd:36745 Declarative Webhooks label Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
#gsd:36745 Declarative Webhooks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants