Avoid live theme from being set in the shopify theme dev session
#4257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
Coverage report
Test suite run success1801 tests passing in 822 suites. Report generated by 🧪jest coverage report action from 19f230f |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
The
_shopify_essentialmay be redefined in the backend with a new theme id. This change ensures the CLI don't use that theme ID and renews the session using the existing workflow defined by the#secure_session_idmethod.WHAT is this pull request doing?
This PR changes the logic in the CLI proxy that renews the
secure_session_id.How to test your changes?
shopify theme dev --verbosePost-release steps
N/A
Measuring impact
How do we know this change was effective? Please choose one:
Checklist