Fix relative webhooks TOML transformation

[gonzaloriestra]

WHY are these changes introduced?

Fixes https://shopify.zendesk.com/agent/tickets/49319741
Fixes Shopify/shopify-app-template-remix#776 (comment)

The link process rewrites the TOML to transform webhook URIs like https://example.com/webhooks to /webhooks when the app URL is https://example.com.

But when the app URL ends with a slash, like https://example.com/, then we were wrongly updating the webhook URI to webhooks, causing the deploy validation to fail.

WHAT is this pull request doing?

Remove the final slash from the app URL when doing that transformation, so the final result includes the required initial slash.

How to test your changes?

• Create an app and run link
• Update the application_url in the TOML to https://whatever.com/
• Add a subscription in the TOML:

  [[webhooks.subscriptions]]
  topics = [ "app/uninstalled" ]
  uri = "https://whatever.com/webhooks"

• Run deploy
• Run link => it should rewrite the uri to /webhooks

Measuring impact

How do we know this change was effective? Please choose one:

• n/a - this doesn't need measurement, e.g. a linting rule or a bug-fix
• Existing analytics will cater for this addition
• PR includes analytics changes to measure impact

Checklist

• I've considered possible cross-platform impacts (Mac, Linux, Windows)
• I've considered possible documentation changes

[github-actions]

Thanks for your contribution!

Depending on what you are working on, you may want to request a review from a Shopify team:

• Themes: @shopify/advanced-edits
• UI extensions: @shopify/ui-extensions-cli
  • Checkout UI extensions: @shopify/checkout-ui-extensions-api-stewardship
• Hydrogen: @shopify/hydrogen
• Other: @shopify/app-management

[github-actions]

Coverage report

St.❔	Category	Percentage	Covered / Total
🟡	Statements	72.51% (+0.11% 🔼)	7848/10824
🟡	Branches	69.47% (+0.05% 🔼)	3863/5561
🟡	Functions	71.24% (+0.03% 🔼)	2061/2893
🟡	Lines	72.82% (+0.12% 🔼)	7412/10179

Test suite run success

1797 tests passing in 818 suites.

Report generated by 🧪jest coverage report action from 253d1ce

[gonzaloriestra]

/snapit

[github-actions]

🫰✨ Thanks @gonzaloriestra! Your snapshot has been published to npm.

Test the snapshot by intalling your package globally:

pnpm i -g [email protected]

After installing, validate the version by running just shopify in your terminal
If the versions don't match, you might have multiple global instances installed.
Use which shopify to find out which one you are running and uninstall it.